stkn/node-pcsclite
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Tests: Add explicit done() calls all round to ensure completion

Browse Source
This commit is contained in:
Roy de Jong
2019-06-06 17:53:11 +02:00
parent bfceac5312
commit b3025141ae
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
test/test.js
View File

@@ -64,7 +64,7 @@ describe('Testing CardReader private', function() {
}); });
}); });
it('#_connect() error', function() { it('#_connect() error', function(done) {
var p = get_reader(); var p = get_reader();
p.on('reader', function(reader) { p.on('reader', function(reader) {
var cb = sinon.spy(); var cb = sinon.spy();
@@ -76,10 +76,11 @@ describe('Testing CardReader private', function() {
reader.connect(cb); reader.connect(cb);
sinon.assert.calledOnce(cb); sinon.assert.calledOnce(cb);
done();
}); });
}); });
it('#_connect() already connected', function() { it('#_connect() already connected', function(done) {
var p = get_reader(); var p = get_reader();
p.on('reader', function(reader) { p.on('reader', function(reader) {
var cb = sinon.spy(); var cb = sinon.spy();
@@ -88,6 +89,7 @@ describe('Testing CardReader private', function() {
reader.connect(cb); reader.connect(cb);
process.nextTick(function () { process.nextTick(function () {
sinon.assert.calledOnce(cb); sinon.assert.calledOnce(cb);
done();
}); });
}); });
}); });
@@ -96,7 +98,7 @@ describe('Testing CardReader private', function() {
describe('#_disconnect()', function() { describe('#_disconnect()', function() {
it('#_disconnect() success', function() { it('#_disconnect() success', function(done) {
var p = get_reader(); var p = get_reader();
p.on('reader', function(reader) { p.on('reader', function(reader) {
reader.connected = true; reader.connected = true;
@@ -108,10 +110,11 @@ describe('Testing CardReader private', function() {
reader.disconnect(cb); reader.disconnect(cb);
sinon.assert.calledOnce(cb); sinon.assert.calledOnce(cb);
done();
}); });
}); });
it('#_disconnect() error', function() { it('#_disconnect() error', function(done) {
var p = get_reader(); var p = get_reader();
p.on('reader', function(reader) { p.on('reader', function(reader) {
reader.connected = true; reader.connected = true;
@@ -123,10 +126,11 @@ describe('Testing CardReader private', function() {
reader.disconnect(cb); reader.disconnect(cb);
sinon.assert.calledOnce(cb); sinon.assert.calledOnce(cb);
done();
}); });
}); });
it('#_disconnect() already disconnected', function() { it('#_disconnect() already disconnected', function(done) {
var p = get_reader(); var p = get_reader();
p.on('reader', function(reader) { p.on('reader', function(reader) {
var cb = sinon.spy(); var cb = sinon.spy();
@@ -138,6 +142,7 @@ describe('Testing CardReader private', function() {
reader.disconnect(cb); reader.disconnect(cb);
process.nextTick(function () { process.nextTick(function () {
sinon.assert.calledOnce(cb); sinon.assert.calledOnce(cb);
done();
}); });
}); });
}); });