stkn/node-pcsclite
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

src: handle last event before exiting status threads

Browse Source 
- Avoid 2 consecutive calls to uv_async_send when exiting the cardreader.cpp
  check status thread.
- Fix mutex unlock location in cardreader.cpp check status thread.

PR-URL: https://github.com/santigimeno/node-pcsclite/pull/46
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This commit is contained in:
Florian Ramillien
2015-09-24 16:33:59 +02:00
committed by Santiago Gimeno
parent 0a3eaafb2b
commit 3800c39291
2 changed files with 29 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/cardreader.cpp
View File

@@ -333,17 +333,7 @@ void CardReader::HandleReaderStatusChange(uv_async_t *handle, int status) {
AsyncResult* ar = async_baton->async_result;
if (ar->do_exit) {
uv_close(reinterpret_cast<uv_handle_t*>(&async_baton->async), CloseCallback); // necessary otherwise UV will block
/* Emit end event */
Local<Value> argv[1] = {
Nan::New("_end").ToLocalChecked(), // event name
};
Nan::MakeCallback(async_baton->reader->handle(), "emit", 1, argv);
} else {
if (ar->result == SCARD_S_SUCCESS) {
if ((ar->result == SCARD_S_SUCCESS) || (ar->result == (LONG)SCARD_E_NO_READERS_AVAILABLE)) {
const unsigned argc = 3;
Local<Value> argv[argc] = {
Nan::Undefined(), // argument
@@ -359,6 +349,17 @@ void CardReader::HandleReaderStatusChange(uv_async_t *handle, int status) {
Local<Value> argv[argc] = { err };
Nan::Callback(Nan::New(async_baton->callback)).Call(argc, argv);
}
// Do exit, after throwing last events
if (ar->do_exit) {
uv_close(reinterpret_cast<uv_handle_t*>(&async_baton->async), CloseCallback); // necessary otherwise UV will block
/* Emit end event */
Local<Value> argv[1] = {
Nan::New("_end").ToLocalChecked(), // event name
};
Nan::MakeCallback(async_baton->reader->handle(), "emit", 1, argv);
}
if (reader->m_status_thread) {
@@ -392,20 +393,21 @@ void CardReader::HandlerFunction(void* arg) {
if (!keep_watching) {
reader->m_state = 2;
async_baton->async_result->do_exit = true;
}
uv_mutex_unlock(&reader->m_mutex);
async_baton->async_result->result = result;
async_baton->async_result->status = card_reader_state.dwEventState;
memcpy(async_baton->async_result->atr, card_reader_state.rgbAtr, card_reader_state.cbAtr);
async_baton->async_result->atrlen = card_reader_state.cbAtr;
uv_mutex_unlock(&reader->m_mutex);
uv_async_send(&async_baton->async);
card_reader_state.dwCurrentState = card_reader_state.dwEventState;
}
async_baton->async_result->do_exit = true;
uv_async_send(&async_baton->async);
// Exit flag set in keepwatching and handled in following uv_async_send
}
void CardReader::DoConnect(uv_work_t* req) {

11
src/pcsclite.cpp
View File

@@ -124,11 +124,6 @@ void PCSCLite::HandleReaderStatusChange(uv_async_t *handle, int status) {
AsyncBaton* async_baton = static_cast<AsyncBaton*>(handle->data);
AsyncResult* ar = async_baton->async_result;
if (ar->do_exit) {
uv_close(reinterpret_cast<uv_handle_t*>(&async_baton->async), CloseCallback); // necessary otherwise UV will block
return;
}
if ((ar->result == SCARD_S_SUCCESS) || (ar->result == (LONG)SCARD_E_NO_READERS_AVAILABLE)) {
const unsigned argc = 2;
Local<Value> argv[argc] = {
@@ -145,6 +140,12 @@ void PCSCLite::HandleReaderStatusChange(uv_async_t *handle, int status) {
Nan::Callback(Nan::New(async_baton->callback)).Call(argc, argv);
}
// Do exit, after throwing last events
if (ar->do_exit) {
uv_close(reinterpret_cast<uv_handle_t*>(&async_baton->async), CloseCallback); // necessary otherwise UV will block
return;
}
/* reset AsyncResult */
delete [] ar->readers_name;
ar->readers_name = NULL;